feat(showcase): embed section #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdrbrnd
requested changes
May 21, 2019
|
Deploy preview ready! https://pr-89.significa.io/ |
pdrbrnd
reviewed
May 21, 2019
| export const Wrapper = styled.div` | ||
| position: relative; | ||
| padding-bottom: 56.25%; /* 16:9 */ | ||
| padding-top: 25px; |
There was a problem hiding this comment.
why this padding-top? I believe we don't have padding in any section and the sectionWrapper takes care of all the top and bottom spacings
There was a problem hiding this comment.
These styles are about this: https://css-tricks.com/NetMag/FluidWidthVideo/Article-FluidWidthVideo.php
pdrbrnd
requested changes
May 21, 2019
|
|
||
| export const Wrapper = styled.div` | ||
| position: relative; | ||
| padding-bottom: 56.25%; /* 16:9 */ |
There was a problem hiding this comment.
Can we safely assume that it's always 16:9?
cc @pedroet
|
Deploy preview ready! https://pr-89.significa.io/ |
|
Deploy preview ready! https://pr-89.significa.io/ |
pdrbrnd
pushed a commit
that referenced
this pull request
Nov 25, 2019
feat(showcase): embed section
tofran
added a commit
that referenced
this pull request
May 15, 2023
Added drawing (segg) authorization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #88